[Identity] Rename use_token_proxy #44147
Open
+54
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
Signed-off-by: Paul Van Eck <[email protected]>
pvaneck
force-pushed
the
identity-rename-proxy-kwarg
branch
from
641a824 to
1e67c3e
Compare
pvaneck
requested review from
JonathanCrd,
KarishmaGhiya,
anannya03,
Copilot,
g2vinay,
joshfree and
maorleger
Copilot finished reviewing on behalf of
pvaneck
November 22, 2025 02:04
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the use_token_proxy keyword argument to enable_azure_proxy in the WorkloadIdentityCredential class to better reflect its purpose. This is a breaking change that only affects code written against beta version 1.26.0b1, as clearly documented in the CHANGELOG.
- Renamed parameter from
use_token_proxytoenable_azure_proxyin both sync and async implementations - Updated all test cases and test documentation to reflect the new parameter name
- Added comprehensive CHANGELOG entry documenting the breaking change with appropriate scope limitation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
sdk/identity/azure-identity/azure/identity/_credentials/workload_identity.py |
Updated sync implementation to use enable_azure_proxy parameter |
sdk/identity/azure-identity/azure/identity/aio/_credentials/workload_identity.py |
Updated async implementation to use enable_azure_proxy parameter |
sdk/identity/azure-identity/tests/test_workload_identity_credential.py |
Updated all sync test method names, docstrings, and parameter usage to reference enable_azure_proxy |
sdk/identity/azure-identity/tests/test_workload_identity_credential_async.py |
Updated all async test method names, docstrings, and parameter usage to reference enable_azure_proxy |
sdk/identity/azure-identity/CHANGELOG.md |
Added breaking change entry documenting the parameter rename with appropriate version scope clarification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44135